fix(ci): make bumping mongosh apply only to mongosh packages#2356
fix(ci): make bumping mongosh apply only to mongosh packages#2356
Conversation
…tests mongosh bump would actually end up overriding most auxiliary packages. This was likely not noticable before as the versions were already aligned and the ordering of the auxiliary bump was after the mongosh bump in tests
gagik
added
the
no-title-validation
| ) | ||
| ).deep.equals({ | ||
| name: '@mongosh/autocomplete', | ||
| version: '1.2.3', |
There was a problem hiding this comment.
We do want to bump these packages, just not with the same version as mongosh, right?
Otherwise the published @mongosh/cli-repl package.json would specify a version that's not actually the same code as the one in the compiled executable?
There was a problem hiding this comment.
yeah, this happens at the previous step with bumpAuxiliaryPackages
There was a problem hiding this comment.
that said, it'd be good to have a test mixing the two. just a bit harder to do it in a clean way because the monorepo bumping helper isn't too easy to control, something more E2E might work but don't know if we want to do that now.
I tried running bump together locally with some overrides for the mongosh bump and seems to work.
2 participants
mongosh bump would actually end up overriding most auxiliary packages. This was likely not noticable before as the versions were already aligned and the ordering of the auxiliary bump was after the mongosh bump in tests